Skip to content

cache pipeline selection #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

cache pipeline selection #1888

wants to merge 4 commits into from

Conversation

wyfo
Copy link
Contributor

@wyfo wyfo commented Apr 7, 2025

supersede #1880 and #1879

@wyfo wyfo requested a review from yellowhatter April 7, 2025 06:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025

PR missing one of the required labels: {'documentation', 'dependencies', 'bug', 'enhancement', 'internal', 'new feature', 'breaking-change'}

@wyfo wyfo added the internal Changes not included in the changelog label Apr 7, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.27%. Comparing base (1a10597) to head (187c512).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
+ Coverage   71.18%   71.27%   +0.08%     
==========================================
  Files         364      364              
  Lines       65647    65666      +19     
==========================================
+ Hits        46733    46803      +70     
+ Misses      18914    18863      -51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yellowhatter
yellowhatter approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@yellowhatter yellowhatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!
Let's wait for @OlivierHecart word on logging and anyway it is OK to merge

@wyfo wyfo requested review from fuzzypixelz and yellowhatter April 8, 2025 12:38
yellowhatter
yellowhatter approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@yellowhatter yellowhatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@yellowhatter
Copy link
Contributor

@fuzzypixelz

@fuzzypixelz
Copy link
Member

@wyfo @yellowhatter Can you provide any performance data?

@yellowhatter
Copy link
Contributor

@wyfo @yellowhatter Can you provide any performance data?

on my machine for 8-byte payload this improves perf 4.9 -> 5.3 M messages per second.

@wyfo
Merge branch 'main' into cache_pipeline
187c512 
# Conflicts:
#	io/zenoh-transport/src/unicast/universal/transport.rs
#	io/zenoh-transport/src/unicast/universal/tx.rs
@OlivierHecart OlivierHecart enabled auto-merge (squash) April 10, 2025 09:46
This was referenced Apr 10, 2025
Closed
Closed
@wyfo wyfo marked this pull request as draft April 15, 2025 08:08
auto-merge was automatically disabled April 15, 2025 08:08

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierHecart OlivierHecart OlivierHecart approved these changes

@fuzzypixelz fuzzypixelz fuzzypixelz approved these changes

@yellowhatter yellowhatter yellowhatter approved these changes

Assignees
No one assigned
Labels
internal Changes not included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyfo @yellowhatter @fuzzypixelz @OlivierHecart