-
Notifications
You must be signed in to change notification settings - Fork 190
support DSCP link config #1937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
support DSCP link config #1937
Conversation
PR missing one of the required labels: {'dependencies', 'breaking-change', 'new feature', 'enhancement', 'bug', 'internal', 'documentation'} |
@JEnoch Could you test that it gives the expected outcome? It seems to work on my laptop, but I would like a more expert review. Also, do you think I went too far in the parsing capabilities? |
Where should this feature be documented? @milyin |
Currently, the only place where we document such endpoint config is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a minimal doc (endpoint examples) in DEFAULT_CONFIG.json5, in a similar way than bind
or iface
options.
❤️ |
Resolves #1924