-
Notifications
You must be signed in to change notification settings - Fork 239
feat: centering banner button #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There are some lint warnings: |
netomi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the lint warning, the change looks good and it centers the Got It button correctly vertically / horizontally depending on the screen size.
I'll take a look what's going on, I would expect this kind of things to be automatically fixed 😅 thanks! |
|
prettier is not yet configured, but we should certainly do that. |
|
these linting issues were autofixable so adding lint-staged + husky for running |
autumnfound
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related to EclipseFdn/open-vsx.org#221
This patch centres the ‘Got it’ button on the vertical axes for desktop, and on the horizontal axes for mobile.
Screen.Recording.2025-11-13.at.11.58.40.mov