Skip to content

Conversation

@gnugomez
Copy link

@gnugomez gnugomez commented Nov 13, 2025

Related to EclipseFdn/open-vsx.org#221

This patch centres the ‘Got it’ button on the vertical axes for desktop, and on the horizontal axes for mobile.

Screen.Recording.2025-11-13.at.11.58.40.mov

@netomi
Copy link

netomi commented Nov 17, 2025

There are some lint warnings:

/home/tn/workspace/eclipse/openvsx/openvsx/webui/src/components/banner.tsx
  42:55  warning  Trailing spaces not allowed  no-trailing-spaces
  43:46  warning  Trailing spaces not allowed  no-trailing-spaces
  44:45  warning  Trailing spaces not allowed  no-trailing-spaces
  46:50  warning  Trailing spaces not allowed  no-trailing-spaces

Copy link

@netomi netomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the lint warning, the change looks good and it centers the Got It button correctly vertically / horizontally depending on the screen size.

@gnugomez
Copy link
Author

There are some lint warnings:

/home/tn/workspace/eclipse/openvsx/openvsx/webui/src/components/banner.tsx
  42:55  warning  Trailing spaces not allowed  no-trailing-spaces
  43:46  warning  Trailing spaces not allowed  no-trailing-spaces
  44:45  warning  Trailing spaces not allowed  no-trailing-spaces
  46:50  warning  Trailing spaces not allowed  no-trailing-spaces

I'll take a look what's going on, I would expect this kind of things to be automatically fixed 😅

thanks!

@netomi
Copy link

netomi commented Nov 17, 2025

prettier is not yet configured, but we should certainly do that.

@gnugomez
Copy link
Author

gnugomez commented Nov 17, 2025

these linting issues were autofixable so adding lint-staged + husky for running eslint --fix should do the trick

Copy link
Contributor

@autumnfound autumnfound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisguindon chrisguindon self-requested a review November 17, 2025 20:44
@chrisguindon chrisguindon requested review from chrisguindon and removed request for chrisguindon November 17, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants