Skip to content

fix: use translated description in Angular Material #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented May 30, 2025

The control description is already translated via JSON Forms core. The potentially translated description is now used instead of manually resolving the description from the schema.

Adds testcases.

The control description is already translated via JSON Forms core. The
potentially translated description is now used instead of manually
resolving the description from the schema.

Adds testcases.
Copy link

netlify bot commented May 30, 2025

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 7ef2b34
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/683a0e13c7e8a000088ca12c
😎 Deploy Preview https://deploy-preview-2454--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sdirix sdirix requested a review from lucas-koehler May 30, 2025 19:59
@coveralls
Copy link

Coverage Status

coverage: 82.573%. remained the same
when pulling 7ef2b34 on sdirix:fix-angular-material-description
into d0b1dfa on eclipsesource:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants