Skip to content

fix: append seconds in Vue Vanilla time #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented May 30, 2025

Appends seconds if necessary in Vue Vanilla time renderer. This makes sure that we do not produce validation errors.

Also allows to configure the "step" attribute via UI Schema options.

Adds test cases.

Appends seconds if necessary in Vue Vanilla time renderer. This makes
sure that we do not produce validation errors.

Also allows to configure the "step" attribute via UI Schema options.

Adds test cases.
@sdirix sdirix requested a review from lucas-koehler May 30, 2025 20:18
Copy link

netlify bot commented May 30, 2025

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit c9d0632
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/683a127c688ff20008b20a3d
😎 Deploy Preview https://deploy-preview-2455--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coveralls
Copy link

Coverage Status

coverage: 82.573%. remained the same
when pulling c9d0632 on sdirix:fix-vue-vanilla-time
into d0b1dfa on eclipsesource:master.

Copy link
Contributor

@lucas-koehler lucas-koehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix :)

@lucas-koehler lucas-koehler merged commit 427ade4 into eclipsesource:master Jun 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time format render doesn't support seconds yet schema validation on time format expects it
3 participants