Skip to content

fix: array layout renderer error count fix #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

fix: array layout renderer error count fix #2477

merged 2 commits into from
Aug 13, 2025
+179 −1

Conversation

martin-trajanovski
Copy link
Contributor

@martin-trajanovski martin-trajanovski commented Aug 12, 2025 •
edited
Loading

Fix for issue #2473

@netlify Netlify
Copy link

netlify bot commented Aug 12, 2025 •
edited
Loading

✅ Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 1856c34
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/689c85b2c6ce3c0008c35ba1
😎 Deploy Preview https://deploy-preview-2477--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@CLAassistant
Copy link

CLAassistant commented Aug 12, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@martin-trajanovski martin-trajanovski marked this pull request as ready for review August 12, 2025 14:19
sdirix
sdirix reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The fix works 🎉, however the test has some issues. Please take a look.

@lucas-koehler lucas-koehler linked an issue Aug 12, 2025 that may be closed by this pull request
Angular material array renderer is showing wrong number of errors in the badge on top of the icon #2473
Closed
@coveralls
Copy link

Coverage Status

coverage: 82.796% (+0.09%) from 82.707%
when pulling 1856c34 on martin-trajanovski:master
into f815e1c on eclipsesource:master.

sdirix
sdirix approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@sdirix sdirix merged commit 0a72bfe into eclipsesource:master Aug 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular material array renderer is showing wrong number of errors in the badge on top of the icon
4 participants
@martin-trajanovski @CLAassistant @coveralls @sdirix