Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Server] Refactor UmlDisposeClientSessionActionHandler to use a ClientSessionListener instead #15

Open
Tracked by #75
CamilleLetavernier opened this issue Jun 11, 2021 · 0 comments

Comments

@CamilleLetavernier
Copy link

UmlDisposeClientSessionActionHandler will only react to DisposeClientSessionAction explicitly sent by the Client to dispose the GLSP/ModelServer connection. If the client disconnects without sending this action (e.g. because the browser tab is closed), UmlDisposeClientSessionActionHandler will never be invoked.

We should refactor this class and implement ClientSessionListener#sessionClosed instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant