You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IF(IUBOUND(1) < NPROMA) THEN
WRITE(NOUT,*)'INV_TRANS:FIRST DIM. OF PGP TOO SMALL/LARGE ',IUBOUND(1),NPROMA
CALL ABORT_TRANS('INV_TRANS:FIRST DIMENSION OF PGP TOO SMALL/LARGE ')
ENDIF
The error message (correctly) states that the first dimension should be NPROMA, and nothing else. The comparison should be /=, not <. I think we should try not to make the interface more generic than needed.
Or line 604:
IF(IUBOUND(1) < NPROMA) THEN
WRITE(NOUT,*)'INV_TRANS:FIRST DIM. OF PGP3B TOO SMALL/LARGE ',IUBOUND(1),NPROMA
CALL ABORT_TRANS('INV_TRANS:FIRST DIMENSION OF PGP3B TOO SMALL/LARGE ')
ENDIF
ELSE
This is actually not even the intent. What should be here is IUBOUND(4) /= NGPBLKS.
I think we should make the interface checks more strict (as much as possible, as little as needed).
What are the steps to reproduce the bug?
Does not apply
Version
develop
Platform (OS and architecture)
Relevant log output
Accompanying data
No response
Organisation
No response
The text was updated successfully, but these errors were encountered:
What happened?
In inv_trans and dir_trans, at least for the GPU, the interface checks are inconsistent.
https://github.com/ecmwf-ifs/ectrans/blob/develop/src/trans/gpu/external/inv_trans.F90
e.g. Line 464
The error message (correctly) states that the first dimension should be NPROMA, and nothing else. The comparison should be
/=
, not<
. I think we should try not to make the interface more generic than needed.Or line 604:
This is actually not even the intent. What should be here is
IUBOUND(4) /= NGPBLKS
.I think we should make the interface checks more strict (as much as possible, as little as needed).
What are the steps to reproduce the bug?
Does not apply
Version
develop
Platform (OS and architecture)
Relevant log output
Accompanying data
No response
Organisation
No response
The text was updated successfully, but these errors were encountered: