Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument checks #222

Merged
merged 6 commits into from
Apr 11, 2025
Merged

Fix argument checks #222

merged 6 commits into from
Apr 11, 2025

Conversation

samhatfield
Copy link
Collaborator

Fixes #220.

@samhatfield samhatfield added the tidying Tidying up code or removing unused features label Mar 3, 2025
@samhatfield samhatfield requested a review from lukasm91 March 3, 2025 14:46
lukasm91
lukasm91 suggested changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@lukasm91 lukasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only went through it very quickly for now.

@samhatfield samhatfield force-pushed the fix_argument_checks branch from de9cf5e to 0737d30 Compare March 3, 2025 15:11
lukasm91
lukasm91 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@lukasm91 lukasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, but if those are addressed, I approve.

@samhatfield samhatfield force-pushed the fix_argument_checks branch 2 times, most recently from 85b67b3 to be7e90b Compare March 4, 2025 11:33
@samhatfield
Improve GATH_GRID consistency checks
33b0106
@samhatfield
Provide more accurate error message in case of wrong KVSET values
32b989b
@samhatfield
Undo consistency check in INV_TRANS
d3b3f0b 
This check was failing when "--vordiv --uvders" was enabled. There may
be a case in the IFS when we pass a PGPUV array with more wind elements
than required to INV_TRANS. This is certainly the case in the benchmark
program, although I think that's just because the code is wrong. The
--vordiv option doesn't enable grid point vorticity and divergence, as
one would expect from the way the PGPUV array is sized. It just enables
transforming of vorticity and divergence to U and V.
@samhatfield
Improve DIST_GRID consistency checks
a2427ee
@samhatfield samhatfield force-pushed the fix_argument_checks branch from be7e90b to a2427ee Compare March 4, 2025 11:36
marsdeno
marsdeno approved these changes Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@marsdeno marsdeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent error message are nice!

@wdeconinck wdeconinck merged commit b0475fd into develop Apr 11, 2025
24 checks passed
@samhatfield samhatfield deleted the fix_argument_checks branch April 11, 2025 10:17
@wdeconinck wdeconinck mentioned this pull request Apr 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasm91 lukasm91 lukasm91 approved these changes

@wdeconinck wdeconinck wdeconinck approved these changes

@marsdeno marsdeno marsdeno approved these changes

Assignees
No one assigned
Labels
tidying Tidying up code or removing unused features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samhatfield @wdeconinck @lukasm91 @marsdeno