-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement INV_TRANSAD
for the GPU branch.
#225
base: develop
Are you sure you want to change the base?
Implement INV_TRANSAD
for the GPU branch.
#225
Conversation
…pack_mod into trmtolad_pack_unpack_mod.
… transi/trans_invtrans_adj.
Thanks @l90lpa - we'll gradually take a look at this. For now I just added some comments to |
Thanks @l90lpa for taking this on!!! |
Thanks for taking a first pass @samhatfield, I'll make those fixes next week (and any others as needed). @wdeconinck it's no problem! |
I'm just working on a pull request directly to your branch which includes the changes above, so no effort required on your part @l90lpa (other than to merge that PR once it's ready!). |
I'm not sure why these gives "not enough slots" errors.
…-contributions ECMWF contributions to feature/invtrans-adjoint
This draft PR implements
INV_TRANSAD
for the GPU branch. I've reused some existing sudroutines from the direct code,TRGTOL
,FTDIR
andLEDIR
, as on inspection they appear to be the same as the adjoints ofTRLTOG
,FTINV
andLEINV
. ForTRMTOL
routines I've added an adjoint as the pack/unpack ofTRLTOM
handle scaling and truncation as well as transposition. Also, I've extended the existing traniinvtrans_adjoint
test to check the vor/div fields, and add a trans test ofINV_TRANSAD
where I've reused some parts of @samhatfield work in #214. One thing I haven't done is fix-up theGSTATS
codes as I'm not exactly sure how the IDs are assigned.