Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement INV_TRANSAD for the GPU branch. #225

Open
wants to merge 42 commits into
base: develop
Choose a base branch
from

Conversation

l90lpa
Copy link
Contributor

@l90lpa l90lpa commented Mar 4, 2025

This draft PR implements INV_TRANSAD for the GPU branch. I've reused some existing sudroutines from the direct code, TRGTOL, FTDIR and LEDIR, as on inspection they appear to be the same as the adjoints of TRLTOG, FTINV and LEINV. For TRMTOL routines I've added an adjoint as the pack/unpack of TRLTOM handle scaling and truncation as well as transposition. Also, I've extended the existing trani invtrans_adjoint test to check the vor/div fields, and add a trans test of INV_TRANSAD where I've reused some parts of @samhatfield work in #214. One thing I haven't done is fix-up the GSTATS codes as I'm not exactly sure how the IDs are assigned.

l90lpa added 29 commits March 4, 2025 14:48
@FussyDuck
Copy link

FussyDuck commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

@samhatfield
Copy link
Collaborator

Thanks @l90lpa - we'll gradually take a look at this. For now I just added some comments to INV_TRANSAD which I spotted when diff'ing against the CPU version.

@wdeconinck
Copy link
Collaborator

Thanks @l90lpa for taking this on!!!

@l90lpa
Copy link
Contributor Author

l90lpa commented Mar 14, 2025

Thanks for taking a first pass @samhatfield, I'll make those fixes next week (and any others as needed). @wdeconinck it's no problem!

@samhatfield samhatfield added enhancement New feature or request gpu labels Mar 14, 2025
@samhatfield
Copy link
Collaborator

Thanks for taking a first pass @samhatfield, I'll make those fixes next week (and any others as needed). @wdeconinck it's no problem!

I'm just working on a pull request directly to your branch which includes the changes above, so no effort required on your part @l90lpa (other than to merge that PR once it's ready!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor enhancement New feature or request gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants