Skip to content

Conversation

grassesi
Copy link
Contributor

@grassesi grassesi commented Oct 16, 2025

Description

PR #905 had a typo in in the backward compatibility mechanism, producing an exception when triggered. This PR contains a hotfix for this bug.

Issue Number

Closes #898

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

Copy link
Collaborator

@clessig clessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but how can one test this? Why didn't this probably occur in every run?

I am again confused by the linting changes but well.

@grassesi
Copy link
Contributor Author

Looks good but how can one test this? Why didn't this probably occur in every run?

It only triggers when you reload from a run config that was produced before this change, so any fresh run is uneffected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Rework configuration for frequency of training artifacts

2 participants