-
Notifications
You must be signed in to change notification settings - Fork 27
fix obs dataset names in stream_mixed #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@@ -7,7 +7,7 @@ | |||
# granted to it by virtue of its status as an intergovernmental organisation | |||
# nor does it submit to any jurisdiction. | |||
|
|||
METEOSAT-X, SEVIRI : | |||
SEVIRI : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change makes logging easier, but I thought these keys follow a specific convention (satellite, instrument).
@clessig , what are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should follow the STAC convention for naming, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that would be best. I will follow the opinion of @clessig on that naming matter though.
@@ -7,7 +7,7 @@ | |||
# granted to it by virtue of its status as an intergovernmental organisation | |||
# nor does it submit to any jurisdiction. | |||
|
|||
NPP, ATMS : | |||
NPPATMS : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do that, I would suggest either NppAtms
(Java) or NPP_ATMS
(python)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, this should be NPP-ATMS according to the STAC convention. I will change it when I get the thumb up from both :)
The problem comes from #283. |
Let's please fixed the cause, not the symptom. |
@kacpnowak : when we re-merge the channel PR we should also fix this. |
Description
fix streams names for NPP ATMS, SEVIRI and SYNOP in steam_mixed to avoid key error not found crash.
Type of Change
Issue Number
related to this issue: #430
Code Compatibility
Code Performance and Testing
uv run train
and (if necessary)uv run evaluate
on a least one GPU node and it works$WEATHER_GENERATOR_PRIVATE
directoryDependencies