-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the possibility to train a model with a dry MLflow run ID #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool feature! I mainly reviewed the code in the command, not so much the functionality during logging and training.
I left some comments @jjlk! let me know if something is not clear, thanks again for the great work! |
Hey @anaprietonem, I think I took into account your comments except the two related to the fork_id because I would like to be sure I really understand the situation. Right now, when you create a forked run, a new MLflow (or with uuid) run ID will be generated by anemoi. What I would like is to generate this MLflow run ID with the If yes, I need a way to pass the MLFlow run ID to |
Added further tests for metadata on MLflow server:
|
Test that everything still works with in offline mode:
then updating everything to the server:
Then result is here: https://mlflow.ecmwf.int/#/experiments/182/runs/bac31bb8cb0549d6b87c05740f56d655. |
… into feature/mlflow-dry-run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great work @jjlk !
Description
If several trainings are chained using a scheduler, a nice feature would be to be able to:
First bullet point is handled with a new CLI to generate a new run ID and to save it on disk and in the register:
Second bullet point is achieved by:
Third bullet point is achieved by:
Examples
Standard training
Creation of a training run ID:
Training:
Forked training
Creation of a training run ID:
Training:
Type of Change
Code Compatibility
Code Testing
Dependencies
Documentation