Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename model_run_ids as trajectory_ids #216

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

mchantry
Copy link
Member

@mchantry mchantry commented Mar 24, 2025

Description

Renames model_run_ids to trajectory_ids to remove confusion with run_ids.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass
  • I have tested the changes on a single GPU
  • I have tested the changes on multiple GPUs / multi-node setups
  • I have run the Benchmark Profiler against the old version of the code
  • If the new feature introduces modifications at the config level, I have made sure to update Pydantic Schemas and default configs accordingly

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.
  • I have not introduced new dependencies in the inference portion of the pipeline

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@FussyDuck
Copy link

FussyDuck commented Mar 24, 2025

CLA assistant check
All committers have signed the CLA.

@mchantry mchantry changed the title Rename model_run_ids as trajectory_ids fix: Rename model_run_ids as trajectory_ids Mar 24, 2025
@anaprietonem anaprietonem merged commit e5e942d into main Mar 25, 2025
28 of 29 checks passed
@anaprietonem anaprietonem deleted the feature/rename_interpolation_ids branch March 25, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants