Skip to content

Conversation

@theissenhelen
Copy link
Collaborator

Description

This PR adds a workflow to run integration tests on a gpu on the HPC. It runs nightly at 22 pm.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass
  • I have tested the changes on a single GPU

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

@github-project-automation github-project-automation bot moved this to Now In Progress in Anemoi-dev Apr 8, 2025
@github-actions github-actions bot added the CI/CD label Apr 8, 2025
@theissenhelen theissenhelen changed the title Test/hpc gpu integration test test: hpc gpu integration test Apr 8, 2025
@theissenhelen theissenhelen changed the title test: hpc gpu integration test ci: hpc gpu integration test Apr 8, 2025
@theissenhelen theissenhelen marked this pull request as ready for review April 8, 2025 10:30
Copy link
Collaborator

@VeraChristina VeraChristina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, many thanks!

Just two small points raised in the comments:

  • Do we want to add a check for the latest commit as in the current nightly workflow?
  • Small questions about the pull_request_target set-up that I am not familiar with

@mchantry mchantry added the ATS Approval Not Needed No approval needed by ATS label Apr 16, 2025
@anaprietonem anaprietonem added the WP4 Activities related to the ML-PP WP4 label Apr 22, 2025
@theissenhelen theissenhelen requested a review from a team as a code owner May 6, 2025 11:40
anaprietonem
anaprietonem previously approved these changes May 15, 2025
Copy link
Contributor

@anaprietonem anaprietonem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Helen!

@theissenhelen theissenhelen merged commit 225d7fd into main May 15, 2025
17 of 20 checks passed
@theissenhelen theissenhelen deleted the test/hpc-gpu-integration-test branch May 15, 2025 13:02
@github-project-automation github-project-automation bot moved this from Now In Progress to Done in Anemoi-dev May 15, 2025
Magnus-SI pushed a commit that referenced this pull request Jun 3, 2025
This adds a workflow for running integration tests on gpu.
matschreiner pushed a commit to matschreiner/anemoi-core that referenced this pull request Jun 4, 2025
This adds a workflow for running integration tests on gpu.
OpheliaMiralles pushed a commit that referenced this pull request Jul 9, 2025
This adds a workflow for running integration tests on gpu.
anaprietonem pushed a commit that referenced this pull request Jul 28, 2025
This adds a workflow for running integration tests on gpu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATS Approval Not Needed No approval needed by ATS CI/CD WP4 Activities related to the ML-PP WP4

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants