Add memory tracing and tracking to Pluto's native memory_resources #271
Conversation
wdeconinck
force-pushed
the
feature/pluto_memory_trace_and_track
branch
from
2896925 to
e1f8b11
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #271 +/- ##
===========================================
- Coverage 79.48% 79.40% -0.09%
===========================================
Files 881 881
Lines 67691 67843 +152
===========================================
+ Hits 53807 53868 +61
- Misses 13884 13975 +91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wdeconinck
force-pushed
the
feature/pluto_memory_trace_and_track
branch
from
e9ee58d to
747fe07
Compare
|
Private downstream CI failed. |
There was a problem hiding this comment.
Thanks @wdeconinck for this PR. Very important work in a nice coding. I have just two remarks.
| @@ -212,7 +212,7 @@ int main(int argc, char* argv[]) { | |||
| // std::pmr::memory_resource* mr = std::pmr::new_delete_resource(); | |||
| auto new_delete_resource = std::make_unique<TraceMemoryResource>("new_delete_resource", std::pmr::new_delete_resource()); | |||
|
|
|||
| auto pinned_resource = std::make_unique<TraceMemoryResource>("pinned_resource", std::make_unique<PinnedMemoryResource>()); | |||
| auto pinned_resource = std::make_unique<TraceMemoryResource>("pinned_resource", pluto::pinned_resource()); | |||
There was a problem hiding this comment.
I am wondering if it is possible to have pluto::traced_pinned_resource("pinned_resource") in addition to pluto::pinned_resource instead of writing: std::make_unique<TraceMemoryResource>("pinned_resource", pluto::pinned_resource()).
There was a problem hiding this comment.
The point of this PR is exactly to not need the TraceMemoryResource anymore. The sandbox code is not yet adapted but just made to compile. This can be for the future.
|
|
||
| #include "MemoryPoolResource.h" | ||
|
|
||
| #define LOG PLUTO_DEBUGGING | ||
|
|
||
| namespace pluto { | ||
|
|
||
| class HostMemoryResource : public async_memory_resource { |
There was a problem hiding this comment.
If async is not utilised in unit tests, perhaps we could stick with just memory_resource for the time being.
There was a problem hiding this comment.
Thank you for this suggestion! I have made the change.
…m resource which happens when bytes > largest_required_pool_block
…mory_tracking, add tracing
wdeconinck
force-pushed
the
feature/pluto_memory_trace_and_track
branch
from
bc7cb20 to
bc41849
Compare
wdeconinck
changed the title
|
Private downstream CI succeeded. |
Add memory tracking and tracing to all pluto memory resources