Add log output when overriding a global option setting #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
<project>_ENABLE_<feature>
variable is used, it's not directly referenced in the ecbuild.log output unless both that andENABLE_<feature>
are present (which triggers a warning). If only the project-specific variable is present and it differs from the default setting, the output can be confusing; for example, if we haveECCODES_ENABLE_NETCDF=OFF
:In the last line the setting is suddenly disabled with no explanation.
The surrounding code has good logging coverage, so a few extra lines here would explain what's going on. This PR inserts a few extra lines of context:
Happy for this to be edited if you think it's now too verbose, but I think at least one extra line here would be useful.