Allow project-specific default option values #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosbento
force-pushed
the
project_specific_default_option_value
branch
from
2cbb0d1 to
f42a883
Compare
|
@marcosbento, note to future self: this PR needs to be merged after PR #82, as the tests depend on those changes to pass. |
This enforces the use of the provided default value, when creating a project-specific option in a multi-project setup. #74
marcosbento
force-pushed
the
project_specific_default_option_value
branch
from
f42a883 to
c39eeaa
Compare
wdeconinck
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
This is a very useful fix. It finally results in expected behaviour, such that a project's default is unaffected by a previous project in a bundle. Thanks @marcosbento !
This may inadvertently affect existing bundle configurations, so a version bump is warranted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces the use of the provided default value, when creating a project-specific option in a multi-project setup.
#74