Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECC-2046: GRIB2: typeOfLevel for heigthAboveGroundAt 0,2,10 metres #303

Closed
wants to merge 2 commits into from

Conversation

rdosinski
Copy link
Collaborator

@rdosinski rdosinski commented Mar 11, 2025

Please merge the branch into develop. It extends the typeOfLevel concept by three additional entries for height above ground at 0, 2 1na 10 metres. This is because the typeOfLevel heigthAboveGround is associated in MARS with either levtype sfc or hl.
levtype hl are normally only height > 10 metres and heights <= 10 metres remain sfc.

See https://jira.ecmwf.int/browse/ECC-2046

@shahramn shahramn self-assigned this Mar 11, 2025
@shahramn shahramn changed the title heightAboveGrountAt{0,2,10}metres additions to typeOfLevel concept ECC-2046: GRIB2: typeOfLevel for heigthAboveGroundAt 0,2,10 metres Mar 11, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (b8c4bcb) to head (d0fc36c).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #303   +/-   ##
========================================
  Coverage    87.59%   87.59%           
========================================
  Files          843      843           
  Lines        62282    62282           
  Branches     11124    11124           
========================================
  Hits         54553    54553           
  Misses        7729     7729           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shahramn shahramn closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants