Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add libfmt #182

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Feature/add libfmt #182

wants to merge 5 commits into from

Conversation

Ozaq
Copy link
Contributor

@Ozaq Ozaq commented Mar 21, 2025

No description provided.

@Ozaq Ozaq force-pushed the feature/add-libfmt branch from e4a62ce to 5ffccda Compare March 21, 2025 22:38
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14002135899.

@Ozaq Ozaq force-pushed the feature/add-libfmt branch from 5ffccda to 4b6d2f6 Compare March 21, 2025 22:49
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 20.45455% with 525 lines in your changes missing coverage. Please review.

Project coverage is 62.24%. Comparing base (9699a1b) to head (7676bb1).

Files with missing lines Patch % Lines
third-party/fmt-11.1.4/include/fmt/format-inl.h 3.14% 400 Missing ⚠️
third-party/fmt-11.1.4/src/os.cc 0.00% 106 Missing ⚠️
third-party/fmt-11.1.4/include/fmt/os.h 0.00% 14 Missing ⚠️
third-party/fmt-11.1.4/include/fmt/chrono.h 55.55% 4 Missing ⚠️
tests/format/test_format_to.cc 98.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
- Coverage    64.31%   62.24%   -2.07%     
===========================================
  Files         1084     1095      +11     
  Lines        55041    57557    +2516     
  Branches      4121     4437     +316     
===========================================
+ Hits         35397    35828     +431     
- Misses       19644    21729    +2085     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ozaq Ozaq force-pushed the feature/add-libfmt branch 2 times, most recently from 326abc7 to d46cff7 Compare March 21, 2025 23:10
@Ozaq Ozaq force-pushed the feature/add-libfmt branch from d46cff7 to f4a90c7 Compare March 21, 2025 23:11
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14002581491.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14003492452.

@pmaciel
Copy link
Member

pmaciel commented Mar 22, 2025

(Not a review)

This is an ideal candidate for git submodules. You can pin to a version, a branch typically main/master. Don't discard the testing....

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14013287677.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14013322210.

@geier1993 geier1993 force-pushed the feature/add-libfmt branch from 83085b6 to d89bddd Compare March 23, 2025 21:45
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14023372025.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14023633597.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14024041579.

@geier1993 geier1993 force-pushed the feature/add-libfmt branch from 23e0ccb to d89bddd Compare March 24, 2025 07:44
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14029932450.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14029984133.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14031334889.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14031516324.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants