Fix for #56, propagating flags to fckit_test_downstream_fypp #58
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #58 +/- ##
========================================
Coverage 51.17% 51.17%
========================================
Files 58 58
Lines 4782 4782
Branches 449 449
========================================
Hits 2447 2447
Misses 2335 2335 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I think there needs to be a further update to src/tests/test_downstream_fypp/compile_flags.cmake on line 11:
set_source_files_properties( downstream_override.fypp PROPERTIES OVERRIDE_COMPILE_FLAGS "-DDOWNSTREAM_COMPILE_FLAGS='"DOWNSTREAM_OVERRIDE_COMPILE_FLAGS"' ${CMAKE_Fortran_FLAGS} ${ECBUILD_Fortran_FLAGS}" )
I.e. adding ECBUILD_Fortran_FLAGS to the end, same as for DOWNSTREAM_Fortran_FLAGS. Without this the downstream_override bit of the test fails in the same way as in the issue.
|
I have now added that. If it works, I will merge. |
* release/0.13.4: Version 0.13.4 Expose fckit_mpi%finalize() (#59) Fix for #56, propagating flags to fckit_test_downstream_fypp (#58) Call ensurepip in fckit_install_venv (#57) FCKIT_VENV: Add support for python3.12 and greater (#54) Add support for COMPILE_OPTIONS to fckit_preprocess_fypp_sources (#55)
* release/0.13.4: Version 0.13.4 Switch actions org from ecmwf-actions to ecmwf (#60) Expose fckit_mpi%finalize() (#59) Fix for #56, propagating flags to fckit_test_downstream_fypp (#58) Call ensurepip in fckit_install_venv (#57) FCKIT_VENV: Add support for python3.12 and greater (#54) Add support for COMPILE_OPTIONS to fckit_preprocess_fypp_sources (#55)
This fixes #56