Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose fckit_mpi%finalize() #59

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Expose fckit_mpi%finalize() #59

merged 1 commit into from
Mar 19, 2025

Conversation

wdeconinck
Copy link
Member

In some cases, e.g. linked with ecmwf/eckit#171 it is advised to finalize MPI before the end of the program.
This can with this PR be done with:

use fckit_module
call fckit_mpi%finalize()

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.10%. Comparing base (ba1da1a) to head (105bc32).

Files with missing lines Patch % Lines
src/fckit/module/fckit_mpi.cc 0.00% 3 Missing ⚠️
src/fckit/module/fckit_mpi.fypp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #59      +/-   ##
===========================================
- Coverage    51.17%   51.10%   -0.07%     
===========================================
  Files           58       58              
  Lines         4782     4788       +6     
  Branches       449      449              
===========================================
  Hits          2447     2447              
- Misses        2335     2341       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wdeconinck wdeconinck merged commit dcdd93c into develop Mar 19, 2025
155 checks passed
wdeconinck added a commit that referenced this pull request Mar 25, 2025
* release/0.13.4:
  Version 0.13.4
  Expose fckit_mpi%finalize() (#59)
  Fix for #56, propagating flags to fckit_test_downstream_fypp (#58)
  Call ensurepip in fckit_install_venv (#57)
  FCKIT_VENV: Add support for python3.12 and greater (#54)
  Add support for COMPILE_OPTIONS to fckit_preprocess_fypp_sources (#55)
wdeconinck added a commit that referenced this pull request Mar 25, 2025
* release/0.13.4:
  Version 0.13.4
  Switch actions org from ecmwf-actions to ecmwf (#60)
  Expose fckit_mpi%finalize() (#59)
  Fix for #56, propagating flags to fckit_test_downstream_fypp (#58)
  Call ensurepip in fckit_install_venv (#57)
  FCKIT_VENV: Add support for python3.12 and greater (#54)
  Add support for COMPILE_OPTIONS to fckit_preprocess_fypp_sources (#55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants