Fieldlocation shared ptr issues #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holds weak_ptr make_shared is wrong; it's not a factory just get shared_ptr
make_shared is wrong, just copy and swap/move it
removed make_shared
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #35 +/- ##
===========================================
+ Coverage 61.57% 61.66% +0.08%
===========================================
Files 274 275 +1
Lines 15234 15248 +14
Branches 1555 1555
===========================================
+ Hits 9381 9403 +22
+ Misses 5853 5845 -8 ☔ View full report in Codecov by Sentry. |
simondsmart
reviewed
Feb 19, 2025
| @@ -56,8 +64,14 @@ class FieldLocation : public eckit::OwnedLock, public eckit::Streamable { | |||
|
|
|||
| virtual eckit::DataHandle* dataHandle() const = 0; | |||
|
|
|||
| /// Create a (shared) copy of the current object, for storage in a general container. | |||
| virtual std::shared_ptr<const FieldLocation> make_shared() const = 0; | |||
|
|
|||
There was a problem hiding this comment.
With these changes we no longer need make_shared. So nuke it.
| FieldLocationFactory::instance().build(uri.scheme(), uri, ref.offset(), ref.length(), remapKey); | ||
| field = Field(std::move(*loc), timestamp_, ref.details()); | ||
| delete (loc); | ||
| std::shared_ptr<FieldLocation> loc |
There was a problem hiding this comment.
I would expect to see a commensurate change to FieldLocationFactory.
If we are saying that the fieldLocations must be shared pointers, then we should create them as such. (Creating a shared pointer in 2 steps, with a raw pointer then a shared pointer object performs 2 memory allocations rather than 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed