Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to reusable action #78

Merged
merged 2 commits into from
Mar 27, 2025
Merged

Switch to reusable action #78

merged 2 commits into from
Mar 27, 2025

Conversation

tmi
Copy link
Contributor

@tmi tmi commented Feb 11, 2025

Switches to reusable action, to have releases for all python versions and platforms

There are two caveats here:

  • this is realistically useful only after https://github.com/ecmwf/metkit/pull/55/files gets merged
  • the name of the resulting wheel is fdblib. That doesn't play well with findlibs.find("fdb5") (which is currently used in pyfdb), and instead findlibs.find("fdb5", "fdblib") is required. Or, we can instead name the wheel fdb5lib -- whatever you guys find suitable
    • EDIT: I've updated the name to fdb5lib

@FussyDuck
Copy link

FussyDuck commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@tmi tmi force-pushed the pyWheel/reusableAction branch from 90615ba to aea3ed1 Compare February 11, 2025 14:49
@Ozaq
Copy link
Contributor

Ozaq commented Feb 11, 2025

Id prefer if the name would match the wrapped .so, i.e. libfdb5 and ofc this makes most sense if this is applied to every wrapper python module. Just my 2 cents :)

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.88%. Comparing base (c3528af) to head (5134a44).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #78      +/-   ##
===========================================
- Coverage    63.90%   63.88%   -0.02%     
===========================================
  Files          281      281              
  Lines        15809    15809              
  Branches      1644     1642       -2     
===========================================
- Hits         10102    10100       -2     
- Misses        5707     5709       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ozaq Ozaq force-pushed the pyWheel/reusableAction branch from aea3ed1 to cdae28e Compare February 12, 2025 13:44
@Ozaq Ozaq force-pushed the pyWheel/reusableAction branch from cdae28e to f937907 Compare March 6, 2025 10:42
@Ozaq Ozaq force-pushed the pyWheel/reusableAction branch from f937907 to 3cfd179 Compare March 21, 2025 19:56
@tmi tmi force-pushed the pyWheel/reusableAction branch from 3cfd179 to 5134a44 Compare March 24, 2025 13:08
@simondsmart simondsmart merged commit 51425aa into develop Mar 27, 2025
146 checks passed
@tmi tmi deleted the pyWheel/reusableAction branch March 28, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants