Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use muti-byte string literals for buffer sizes #97

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Ozaq
Copy link
Contributor

@Ozaq Ozaq commented Mar 14, 2025

EDIT: I cannot move the PR back to in-draft but this needs to wait until eckit 1.28.6 is released.


With multi-byte string literals available in eckit we can start using them in fdb.

@Ozaq Ozaq requested a review from ChrisspyB March 14, 2025 14:04
@ChrisspyB
Copy link
Member

This should presumably also update the minimum eckit version in the cmake lists

@Ozaq
Copy link
Contributor Author

Ozaq commented Mar 14, 2025

This should presumably also update the minimum eckit version in the cmake lists

Oh good catch, so that should then probably be the next to-be-released version of eckit, right?

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 34.78261% with 15 lines in your changes missing coverage. Please review.

Project coverage is 63.84%. Comparing base (d9c77cd) to head (4d96d82).

Files with missing lines Patch % Lines
src/fdb5/remote/server/StoreHandler.cc 0.00% 3 Missing ⚠️
src/fdb5/io/LustreSettings.cc 0.00% 2 Missing ⚠️
src/fdb5/remote/server/CatalogueHandler.cc 0.00% 2 Missing ⚠️
src/fdb5/toc/RootManager.cc 33.33% 2 Missing ⚠️
src/fdb5/tools/fdb-hammer.cc 0.00% 2 Missing ⚠️
src/fdb5/database/Manager.cc 0.00% 1 Missing ⚠️
src/fdb5/remote/server/AvailablePortList.cc 0.00% 1 Missing ⚠️
src/fdb5/remote/server/ServerConnection.cc 0.00% 1 Missing ⚠️
src/fdb5/toc/TocStore.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #97   +/-   ##
========================================
  Coverage    63.84%   63.84%           
========================================
  Files          281      281           
  Lines        15815    15815           
  Branches      1643     1643           
========================================
  Hits         10097    10097           
  Misses        5718     5718           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ozaq Ozaq force-pushed the feature/use-multi-byte-literals branch from 3e18b1f to 913e9e8 Compare March 14, 2025 14:26
@Ozaq Ozaq force-pushed the feature/use-multi-byte-literals branch from 913e9e8 to d4e3628 Compare March 26, 2025 10:55
@Ozaq Ozaq force-pushed the feature/use-multi-byte-literals branch from d4e3628 to 4d96d82 Compare April 9, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants