-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First search in installed packages #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14 +/- ##
===========================================
- Coverage 41.91% 33.48% -8.43%
===========================================
Files 4 6 +2
Lines 136 218 +82
===========================================
+ Hits 57 73 +16
- Misses 79 145 +66 ☔ View full report in Codecov by Sentry. |
bd8d8e5
to
a19ea14
Compare
a19ea14
to
fdd4763
Compare
fdd4763
to
6854f9e
Compare
iainrussell
reviewed
Nov 29, 2024
304111d
to
6581389
Compare
ef16d92
to
d530acf
Compare
764d0cf
to
9ecc085
Compare
This was referenced Dec 16, 2024
Hi @tmi , I'm happy to merge this in if you are, and I can make a release from it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/ Adding a new source for searching for libs -- in installed python binary packages. Those are produced eg here https://github.com/ecmwf/eckit/pull/152/commits . This additionally extend ld library path for transitive dependencies, assuming the found libs declare them accordingly
2/ Refactored the body of the main function so that each source is separated in its own (private) function
3/ Fine-grained control over which sources are allowed for package search using environment variables