Release 0.1.0 #15
Merged
Release 0.1.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my Mac machine, if I follow the odc build instructions and run `make install` I find that `libodccore.dylib ` ends up
in `~/local/lib/libodccore.dylib` and `find("odccore", pkg_name="odc")` cannot find it.
Hence I suggest adding `os.path.expanduser("~/local")` to the list of search directories for globally installed files.
The alternative fix might be to add a way for `make install` to install to "$CONDA_PREFIX/lib/libodccore.dylib" since that is the first place`find` looks and seems like a reasonable place for ODCs`make install` command to put its libraries.
…path Feature: optional config file at ~/.findlibs and adding ~/.local to search path
Feature/add docs
* Add to downstream ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage ? 33.48%
=========================================
Files ? 6
Lines ? 218
Branches ? 0
=========================================
Hits ? 73
Misses ? 145
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.