Fix ctypes.util.find_library usage #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0.0.5 the ctypes.util.find_library fallback searched for lib_name without the "lib" prefix. Using the prefix breaks the fallback on some platforms: Ubuntu 16.04, 20.04, 22.04. Fix this by trying both name conventions
|
|
|
Caution This pull request contains changes to GitHub workflows! |
|
Fix: #17 |
|
+1 for this fix. It solved some problems on Debian Bookworm (in the context of Raspberry Pi OS, aarch64-linux-gnu) running Python 3.11. |
25 tasks
|
Hi, thanks for working on this PR. We would like to use this in our next release of the Online Laboratory for Data Compression in Climate Science and Meteorology, which is part of the ESiWACE3 project and joint work between University of Helsinki (@juntyr) and ECMWF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.0.5 the ctypes.util.find_library fallback searched for lib_name without the "lib" prefix.
Using the prefix breaks the fallback on some platforms: Ubuntu 16.04, 20.04, 22.04. Fix this by trying both name conventions