Feature/faster ccsds offsets #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #42 +/- ##
===========================================
+ Coverage 61.95% 68.31% +6.36%
===========================================
Files 92 92
Lines 4707 4270 -437
Branches 502 395 -107
===========================================
+ Hits 2916 2917 +1
+ Misses 1791 1353 -438 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up scanning by reducing compute spent on decoding the data section when all we want are the chunk offsets.
Decoding involves two steps: a call to aec_decode and an additional decoding step (adding a reference value to each value and multiplying by the binary scale factor). This PR speeds up the offsets calculation by not doing this latter step.
Also using this as an opportunity to do some clean up of the decoding code, which has been on the back log for a long time. I would like to do a more significant refactoring later, in a different PR.