Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/short lived fdb #43

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Feature/short lived fdb #43

merged 2 commits into from
Mar 17, 2025

Conversation

ChrisspyB
Copy link
Member

Rather than one infinitely long lived fdb object in FDBLister, we instead always create a new one when we receieve a new request. We also no longer lock FDB axes behind a mutex.

This assumes that:

  • FDB list and axes no longer has thread-safety issues.
  • FDB no longer has destruction issues.

Do not merge until some stress testing has taken place with many parallel requests. Need to test local FDB (atos) and remote FDB (lumi databridge)

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.88%. Comparing base (e1115bf) to head (57d41a6).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
src/gribjump/remote/GribJumpUser.cc 0.00% 6 Missing ⚠️
src/gribjump/Lister.cc 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #43      +/-   ##
===========================================
- Coverage    61.95%   61.88%   -0.07%     
===========================================
  Files           92       91       -1     
  Lines         4707     4709       +2     
  Branches       502      502              
===========================================
- Hits          2916     2914       -2     
- Misses        1791     1795       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisspyB ChrisspyB merged commit 32be5b5 into develop Mar 17, 2025
110 checks passed
@ChrisspyB ChrisspyB deleted the feature/short-lived-fdb branch March 17, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants