-
Couldn't load subscription status.
- Fork 9
[WIP]: Remove DummyContext #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Waiting for the CICD to see whether parts of the stack were relying on the functionality (I only checked the mars-client-bundle so far). |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #106 +/- ##
===========================================
+ Coverage 70.12% 70.42% +0.30%
===========================================
Files 135 134 -1
Lines 8143 8166 +23
Branches 780 779 -1
===========================================
+ Hits 5710 5751 +41
+ Misses 2433 2415 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I'd like to have a chat with you/Emanuele about this one. I think I would have to do a lot of reading before I could review it on-spec. |
Description
This is a WIP branch to get rid of the context in all of the expansion methods. The call tree relied on a DummyContext object being passed through several layers of the Code. There was no usage in the inner functions, rendering the object useless. I removed it form the function definitions.
Contributor Declaration
By opening this pull request, I affirm the following: