Skip to content

Conversation

@tbkr
Copy link
Contributor

@tbkr tbkr commented Aug 21, 2025

Description

This is a WIP branch to get rid of the context in all of the expansion methods. The call tree relied on a DummyContext object being passed through several layers of the Code. There was no usage in the inner functions, rendering the object useless. I removed it form the function definitions.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@tbkr tbkr requested a review from danovaro August 21, 2025 17:13
@tbkr
Copy link
Contributor Author

tbkr commented Aug 21, 2025

Waiting for the CICD to see whether parts of the stack were relying on the functionality (I only checked the mars-client-bundle so far).

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2025

Codecov Report

❌ Patch coverage is 83.91608% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.42%. Comparing base (17e4fca) to head (f161ff8).

Files with missing lines Patch % Lines
src/metkit/mars/MarsExpansion.cc 35.29% 11 Missing ⚠️
src/metkit/mars/Type.cc 69.23% 4 Missing ⚠️
src/metkit/mars/MarsParsedRequest.cc 25.00% 3 Missing ⚠️
src/metkit/mars/MarsExpansion.h 0.00% 1 Missing ⚠️
src/metkit/mars/MarsLanguage.cc 92.85% 1 Missing ⚠️
src/metkit/mars/MarsParser.cc 50.00% 1 Missing ⚠️
src/metkit/mars/Parameter.cc 0.00% 1 Missing ⚠️
src/metkit/mars/TypeParam.cc 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #106      +/-   ##
===========================================
+ Coverage    70.12%   70.42%   +0.30%     
===========================================
  Files          135      134       -1     
  Lines         8143     8166      +23     
  Branches       780      779       -1     
===========================================
+ Hits          5710     5751      +41     
+ Misses        2433     2415      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simondsmart
Copy link
Contributor

I'd like to have a chat with you/Emanuele about this one. I think I would have to do a lot of reading before I could review it on-spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants