Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gribhandle on Mac for file with multiple messages #45

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

ChrisspyB
Copy link
Member

Also add a unit test

@ChrisspyB ChrisspyB requested a review from danovaro April 5, 2024 17:19
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.82%. Comparing base (6a4ab3a) to head (999a204).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #45      +/-   ##
===========================================
+ Coverage    57.02%   57.82%   +0.80%     
===========================================
  Files           99      100       +1     
  Lines         5940     5961      +21     
===========================================
+ Hits          3387     3447      +60     
+ Misses        2553     2514      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danovaro danovaro merged commit fb194f8 into develop Apr 5, 2024
70 checks passed
@danovaro danovaro deleted the bugfix/gribhandle branch April 5, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants