Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unique_ptr usage from Type #62

Merged
merged 8 commits into from
Mar 25, 2025
Merged

Conversation

mcakircali
Copy link
Contributor

as discussed with Tiago, remove unique_ptr to keep ECMWF's raw pointer idiom

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 51.35135% with 18 lines in your changes missing coverage. Please review.

Project coverage is 61.20%. Comparing base (5156af4) to head (2345ae9).

Files with missing lines Patch % Lines
src/metkit/mars/Type.cc 50.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #62      +/-   ##
===========================================
- Coverage    61.31%   61.20%   -0.12%     
===========================================
  Files          102      102              
  Lines         6414     6421       +7     
  Branches       611      611              
===========================================
- Hits          3933     3930       -3     
- Misses        2481     2491      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@simondsmart simondsmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
My preference would be to keep unique_ptr in the containers, and the raw pointers on the interface.

@mcakircali mcakircali force-pushed the feat/revert-mem-leak-fix branch from af9f947 to de4135d Compare February 19, 2025 13:36
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13414468619.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13414618937.

@simondsmart simondsmart added the approved-for-ci Approved for CI run label Feb 19, 2025
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13588436925.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13588533098.

Copy link

github-actions bot commented Mar 1, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13602661633.

Copy link

github-actions bot commented Mar 1, 2025

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/13602677844.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/14061733794.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/14062192740.

@mcakircali mcakircali requested a review from danovaro March 25, 2025 14:53
Copy link
Member

@danovaro danovaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @mcakircali

@danovaro danovaro removed the request for review from simondsmart March 25, 2025 15:27
@danovaro danovaro merged commit a330cd0 into develop Mar 25, 2025
152 checks passed
@danovaro danovaro deleted the feat/revert-mem-leak-fix branch March 25, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-for-ci Approved for CI run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants