-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert unique_ptr usage from Type #62
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #62 +/- ##
===========================================
- Coverage 61.31% 61.20% -0.12%
===========================================
Files 102 102
Lines 6414 6421 +7
Branches 611 611
===========================================
- Hits 3933 3930 -3
- Misses 2481 2491 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
My preference would be to keep unique_ptr in the containers, and the raw pointers on the interface.
af9f947
to
de4135d
Compare
Private downstream CI failed. |
Private downstream CI succeeded. |
Private downstream CI succeeded. |
Private downstream CI succeeded. |
Private downstream CI succeeded. |
Private downstream CI succeeded. |
Private downstream CI succeeded. |
Private downstream CI succeeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @mcakircali
as discussed with Tiago, remove unique_ptr to keep ECMWF's raw pointer idiom