-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Wrapper Wheel #53
base: develop
Are you sure you want to change the base?
Conversation
@@ -6,9 +6,9 @@ doc/latex | |||
*.sublime-workspace | |||
.*.sw* | |||
.*un~ | |||
build* | |||
build/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I'm not breaking something here. But note that the original statement ignored files such as .github/workflows/build-linux-wheel.yml
, which I guess is not desirable (at least not for me :) )
ac57b56
to
3e3b2f6
Compare
@geier1993 I've run into an issue in this PR, in particular, the pyproject.toml and the respective pymultio package interfere with the python wrapper. Since we'll be building two wheels from a single repo, I've separated them at the top level, via I didn't find anything assuming that the pymultio is located at the root of the repo -- ie, no action, no script, etc. Did I miss something? I've just changed the relative reference to LICENSE from pyproject.toml I haven't yet changed the pymultio package to utilize the python wrapper wheel (to get rid of the need for local builds), as that requires other PRs elsewhere to be merged. But unless you'd object, I'll do it later too :) Also, the layout is quite odd, like including readme and requirements inside the package directory -- has there been a reason for that? |
and I guess https://github.com/ecmwf/multio-python/ should be archived, right? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #53 +/- ##
========================================
Coverage 52.37% 52.37%
========================================
Files 214 214
Lines 14609 14609
Branches 1221 1221
========================================
Hits 7652 7652
Misses 6957 6957 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bc0cb5d
to
dd4fa5a
Compare
https://github.com/ecmwf/codex/blob/dda298943d0241a48c039fc826e72f94c55b2493/Languages/python_wheels.md