Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Wrapper Wheel #53

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Python Wrapper Wheel #53

wants to merge 4 commits into from

Conversation

tmi
Copy link

@tmi tmi commented Feb 6, 2025

@FussyDuck
Copy link

FussyDuck commented Feb 6, 2025

CLA assistant check
All committers have signed the CLA.

@@ -6,9 +6,9 @@ doc/latex
*.sublime-workspace
.*.sw*
.*un~
build*
build/*
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I'm not breaking something here. But note that the original statement ignored files such as .github/workflows/build-linux-wheel.yml, which I guess is not desirable (at least not for me :) )

@tmi tmi force-pushed the project/wheelify branch 2 times, most recently from ac57b56 to 3e3b2f6 Compare February 13, 2025 08:03
@tmi tmi changed the title Python Wheel: initial commit Python Wrapper Wheel Feb 13, 2025
@tmi
Copy link
Author

tmi commented Feb 13, 2025

@geier1993 I've run into an issue in this PR, in particular, the pyproject.toml and the respective pymultio package interfere with the python wrapper. Since we'll be building two wheels from a single repo, I've separated them at the top level, via python_wrapper/ and python_interface/ prefixes (I'm using the same convention eg in metkit as well ftr)

I didn't find anything assuming that the pymultio is located at the root of the repo -- ie, no action, no script, etc. Did I miss something? I've just changed the relative reference to LICENSE from pyproject.toml

I haven't yet changed the pymultio package to utilize the python wrapper wheel (to get rid of the need for local builds), as that requires other PRs elsewhere to be merged. But unless you'd object, I'll do it later too :) Also, the layout is quite odd, like including readme and requirements inside the package directory -- has there been a reason for that?

@tmi tmi marked this pull request as ready for review February 13, 2025 10:46
@tmi
Copy link
Author

tmi commented Feb 13, 2025

and I guess https://github.com/ecmwf/multio-python/ should be archived, right?

@tmi tmi force-pushed the project/wheelify branch from 14c140e to 13a0c36 Compare March 24, 2025 12:39
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.37%. Comparing base (71c017d) to head (dd4fa5a).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #53   +/-   ##
========================================
  Coverage    52.37%   52.37%           
========================================
  Files          214      214           
  Lines        14609    14609           
  Branches      1221     1221           
========================================
  Hits          7652     7652           
  Misses        6957     6957           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmi tmi force-pushed the project/wheelify branch from c285cfc to bc0cb5d Compare March 24, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants