Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference operators in statistics action #60

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

tweska
Copy link
Member

@tweska tweska commented Mar 11, 2025

Added both difference operators from: https://codes.ecmwf.int/grib/format/grib2/ctables/4/10/

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 91.73228% with 21 lines in your changes missing coverage. Please review.

Project coverage is 54.18%. Comparing base (199e3ea) to head (b42f8c6).

Files with missing lines Patch % Lines
...c/multio/action/statistics/operations/Difference.h 69.23% 8 Missing ⚠️
...o/action/statistics/operations/InverseDifference.h 69.23% 8 Missing ⚠️
src/multio/action/statistics/Operations.h 60.00% 4 Missing ⚠️
...sts/multio/action/statistics/testStatisticsUtils.h 96.96% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #60      +/-   ##
===========================================
+ Coverage    53.21%   54.18%   +0.97%     
===========================================
  Files          218      223       +5     
  Lines        14813    15062     +249     
  Branches      1222     1246      +24     
===========================================
+ Hits          7882     8162     +280     
+ Misses        6931     6900      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tweska tweska force-pushed the feature/diff-ops branch from 7c215ef to 8abb434 Compare March 21, 2025 12:30
@tweska tweska requested a review from dsarmany March 21, 2025 12:43
Copy link
Collaborator

@MircoValentiniECMWF MircoValentiniECMWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add seed to the random vector

@tweska tweska force-pushed the feature/diff-ops branch from 8abb434 to 4eaa22b Compare March 25, 2025 15:05
Copy link
Collaborator

@MircoValentiniECMWF MircoValentiniECMWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the default 42

@dsarmany dsarmany merged commit 269371d into develop Mar 25, 2025
124 checks passed
@dsarmany dsarmany deleted the feature/diff-ops branch March 25, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants