Adding a passthrough option to the statistic action #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefaniereuter
requested review from
geier1993,
tweska,
dsarmany and
MircoValentiniECMWF
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #61 +/- ##
===========================================
+ Coverage 53.06% 53.08% +0.01%
===========================================
Files 217 217
Lines 14644 14655 +11
Branches 1213 1213
===========================================
+ Hits 7771 7779 +8
- Misses 6873 6876 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geier1993
reviewed
Mar 13, 2025
| void StatisticsOptions::parseInitialDataPassThrough(const eckit::LocalConfiguration& cfg) { | ||
| //This option needs to be set if we have two statistic actions in a plan. Then the second statistic action also needs the initial data to create the statistic window correctly. | ||
| //Therefore the first action needs to have this option set to true. | ||
| initDataPassTrough_ = cfg.getBool("initial-data-passed-through", false); |
There was a problem hiding this comment.
should the option really be named ...-passed-through or ...-pass-through
| // AND the model sends initial data AND the internal tracker if any message has been directly passed through is still false the message is passed through to the next action | ||
| // TODO check if this is a good position for this check. It looks like the next chekc would filter this message out anyway. | ||
| //std::cout<<"STEBA opt_.solver_send_initial_condition() " << opt_.solver_send_initial_condition() << " opt_.initialDataPassThrough() " << opt_.initialDataPassThrough() <<" !initialDataAlreadyPassedThrough_ " << !initialDataAlreadyPassedThrough_ << std::endl; | ||
| if(opt_.solver_send_initial_condition() && opt_.initialDataPassThrough() && !initialDataAlreadyPassedThrough_) { |
There was a problem hiding this comment.
So this assumes - without checking the metadata - that the
user properly configured the action to what the model is sending.
Is it possible to assert some things? I.e. a pass through message has step=0 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a draft PR for the first statistic change option that we discussed. Draft because I would like to add a test but would like to start discussions already as there are a few points that probably need it:
Foremost the position, where to pass on the initial data.