Use Log output instead of standard out #62
Conversation
stefaniereuter
requested review from
geier1993,
tweska,
dsarmany and
MircoValentiniECMWF
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #62 +/- ##
========================================
Coverage 53.06% 53.06%
========================================
Files 217 217
Lines 14644 14644
Branches 1213 1213
========================================
Hits 7771 7771
Misses 6873 6873 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I wasn't aware of this macro, I used |
|
@tweska As far as I know @MircoValentiniECMWF also had longer discussions with @geier1993 and @dsarmany of having multiple MULTIO flags to enable debug on specific code regions. e.g. Multio_statistic ... |
| @@ -61,14 +62,14 @@ ConfigAndPaths configureFromEnv(config::LocalPeerTag tag) { | |||
|
|
|||
| if (::getenv("MULTIO_PLANS")) { | |||
| std::string cfg(::getenv("MULTIO_PLANS")); | |||
| std::cout << "MultIO initialising with plans " << cfg << std::endl; | |||
| LOG_DEBUG_LIB(LibMultio) << "MultIO initialising with plans " << cfg << std::endl; | |||
There was a problem hiding this comment.
You may want to use eckit::Log::info(), no? I think there is no harm printing this all the time as the output is fairly limited.
There was a problem hiding this comment.
Maybe we should consider printing this only from one server
There was a problem hiding this comment.
I like the idea of only printing it from one server. This would be another reason to have this IO-Server "Master".
There was a problem hiding this comment.
You may want to use
eckit::Log::info(), no? I think there is no harm printing this all the time as the output is fairly limited.
Well for smaller runs it is limited but if they run larger production runs it does get more annoying. The information in general is useful, we probably just don't want to have it printed so often.
Essentially this is a non urgent, "make it look prettier", idea, to reduce log messages that can't be turned off. The output scripts are annoying to search through as it.
There was a problem hiding this comment.
Okay, I can just merge this and see how much it is missed. Then we can come up with a cleverer solution.
this is a suggestion to avoid spamming the output in runs. With many IO servers this can sometimes become a long list.