Remove dependency on atlasIO #64
Conversation
| @@ -109,6 +108,7 @@ void AtlasIO::checkFileExist(const std::string& name) const { | |||
| return; | |||
| }; | |||
|
|
|||
| StatisticsIOBuilder<AtlasIO> AtalsIOBuilder("atlas_io"); | |||
| StatisticsIOBuilder<EckitCodecIO> EckitCodecIOBuilder("eckit_codec"); | |||
| StatisticsIOBuilder<EckitCodecIO> AtlasIOBuilder("atlas_io"); // Legacy name | |||
There was a problem hiding this comment.
This is a fix to make sure plans with restart-lib: "atlas_io" do not break for now.
There was a problem hiding this comment.
do we really want to have this legacy feature??
We tag the branches anyway. So for me it would be fine that projects that upgrade will have to update their configuration properly. Someday this has to be done anyway.
There was a problem hiding this comment.
@tweska -- Check with Steffi if there are any multio plans currently that use atlas_io. In general, I'm also in favour of getting rid of this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #64 +/- ##
========================================
Coverage 53.07% 53.07%
========================================
Files 218 218
Lines 14840 14840
Branches 1221 1221
========================================
Hits 7877 7877
Misses 6963 6963 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tweska
force-pushed
the
feature/remove-atlas-io
branch
from
a2f6505 to
096b0f1
Compare
tweska
force-pushed
the
feature/remove-atlas-io
branch
from
096b0f1 to
7bf4c3f
Compare
tweska
force-pushed
the
feature/remove-atlas-io
branch
from
7bf4c3f to
e048acd
Compare
No description provided.