Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all curly during multio configuration initialization #67

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tweska
Copy link
Member

@tweska tweska commented Mar 21, 2025

Instead of having to call replace curly for each option separately, this change will expand all the curly brackets for every string value when the multio configuraiton is initialized.

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 77.64706% with 19 lines in your changes missing coverage. Please review.

Project coverage is 53.20%. Comparing base (9d06daf) to head (11ece82).

Files with missing lines Patch % Lines
src/multio/config/PlanConfiguration.cc 50.00% 4 Missing ⚠️
src/multio/util/Substitution.cc 71.42% 4 Missing ⚠️
.../multio/action/statistics/cfg/StatisticsOptions.cc 66.66% 3 Missing ⚠️
src/multio/action/encode/GridDownloader.cc 0.00% 2 Missing ⚠️
src/multio/sink/FileSink.cc 50.00% 2 Missing ⚠️
src/multio/action/encode/Encode.cc 50.00% 1 Missing ⚠️
src/multio/action/encode/GribEncoder.cc 0.00% 1 Missing ⚠️
...ultio/action/interpolate-fesom/InterpolateFesom.cc 0.00% 1 Missing ⚠️
src/multio/config/MultioConfiguration.cc 97.22% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #67      +/-   ##
===========================================
+ Coverage    53.07%   53.20%   +0.12%     
===========================================
  Files          218      218              
  Lines        14840    14810      -30     
  Branches      1221     1222       +1     
===========================================
+ Hits          7877     7879       +2     
+ Misses        6963     6931      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants