Fix comparison between int and bool. #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -725,7 +725,7 @@ PP_THREAD_SAFE FUNCTION GRIB2_SECTION4_MODEL_PRESET( THIS, & | |||
| CALL GRIB_IS_DEFINED( HANDLE, 'localDefinitionNumber', IS_DEFINED, STATUS=KRET ) | |||
| PP_DEBUG_CRITICAL_COND_THROW( KRET.NE.GRIB_SUCCESS , ERRFLAG_UNABLE_TO_CHECK_IS_DEFINED ) | |||
|
|
|||
| IF( IS_DEFINED) THEN | |||
| IF( IS_DEFINED.GT.0 ) THEN | |||
There was a problem hiding this comment.
Thanks for addressing this—it was a real bug, and I appreciate the fix! While it’s true that some compilers are more lenient, that doesn’t justify leaving the issue unaddressed, so good catch here.
One minor suggestion: I’d recommend tweaking the check to use (IS_DEFINED .NE. 0) instead. It’s a cosmetic preference, but I think it reads a bit more clearly. That said, since the grib_is_defined function from the GRIB API only returns 0 or 1, your current implementation (IS_DEFINED .GT. 0) works perfectly fine either way.
Great work overall!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cray compiler fails with error if comparing LOGICAL and INTEGER.