Skip to content

Handle exceptions by reference #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Handle exceptions by reference #34

wants to merge 1 commit into from

Conversation

pmaciel
Copy link
Member

@pmaciel pmaciel commented Mar 20, 2025

This is good practice. Related to PR
ecmwf/eckit#179

@pmaciel pmaciel requested a review from simondsmart March 20, 2025 22:43
@FussyDuck
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.18%. Comparing base (d025fb1) to head (5b445e9).

Files with missing lines Patch % Lines
src/odc/odccapi.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #34      +/-   ##
===========================================
- Coverage    87.18%   87.18%   -0.01%     
===========================================
  Files          189      188       -1     
  Lines        15043    15041       -2     
  Branches      1352     1352              
===========================================
- Hits         13115    13113       -2     
  Misses        1928     1928              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants