Added emulator tool #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/nwp-emulator-grib-source #4 +/- ##
=====================================================================
+ Coverage 30.51% 48.92% +18.41%
=====================================================================
Files 48 55 +7
Lines 1904 2475 +571
Branches 128 241 +113
=====================================================================
+ Hits 581 1211 +630
+ Misses 1323 1264 -59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dsarmany
requested changes
Mar 7, 2025
src/nwp_emulator/nwp_emulator.cc
Outdated
| * @class NWPEmulator | ||
| * @brief Emulates a model run and makes data available at each time step to facilitate Plume and plugins testing. | ||
| */ | ||
| class NWPEmulator : public atlas::AtlasTool { |
There was a problem hiding this comment.
Worth sticking a final here?
| } | ||
|
|
||
| eckit::mpi::comm().barrier(); | ||
| std::cout << "Process " << rank << " finished..." << std::endl; |
There was a problem hiding this comment.
As mentioned, I use the standard output here to see some logging from all processes as with eckit only the root writes to the standard output.
src/nwp_emulator/nwp_emulator.cc
Outdated
| plume::Protocol offers; /// Define data offered by Plume | ||
| offers.offerInt("NSTEP", "always", "Simulation Step"); | ||
| auto fields = dataProvider.getModelFieldSet(); | ||
| for (size_t i = 0; i < fields.size(); ++i) { |
There was a problem hiding this comment.
Can't we just use for (const auto& field : fields).
src/nwp_emulator/nwp_emulator.cc
Outdated
| } | ||
| plume::Manager::negotiate(offers); | ||
| plumeData_.createInt("NSTEP", 0); /// Initialise parameters | ||
| for (size_t i = 0; i < fields.size(); ++i) { |
There was a problem hiding this comment.
Same as above, use range-based for loop.
antons-it
approved these changes
Mar 14, 2025
| std::string usage() override { | ||
| return name() + | ||
| " [--grib-src=<path> | --config-src=<path>] [--plume-cfg=<path>] [OPTION]... [--help]\n" | ||
| " --plume-cfg is optional, pass it to run Plume, else the emulator will do a dry run\n"; |
There was a problem hiding this comment.
nice to have the "dry-run" option
cducher
force-pushed
the
feature/nwp-emulator-grib-source
branch
2 times, most recently
from
dacb4aa to
ffe3b93
Compare
dsarmany
approved these changes
Mar 21, 2025
cducher
force-pushed
the
feature/nwp-emulator
branch
from
0e01528 to
8e78367
Compare
cducher
force-pushed
the
feature/nwp-emulator-grib-source
branch
from
ffe3b93 to
6ce826a
Compare
cducher
force-pushed
the
feature/nwp-emulator
branch
from
772e3d8 to
407622c
Compare
cducher
force-pushed
the
feature/nwp-emulator
branch
from
222a2d5 to
4e53633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the Atlas emulator tool implementation, which makes use of the GRIB reader reviewed in this PR.
/!\ there is a parallelisation bug in the paramBuffer broadcast of the GRIB reader, so running with 3, or 5+ processes do not work at the moment. You can try this emulator with 1,2, or 4 processes at the moment. UPDATE: this is fixed in the GRIB PR