Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for the NWP Emulator #7

Merged

Conversation

cducher
Copy link
Contributor

@cducher cducher commented Mar 12, 2025

No description provided.

@cducher cducher requested review from dsarmany and antons-it March 12, 2025 17:42
@cducher cducher self-assigned this Mar 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes missing coverage. Please review.

Project coverage is 48.87%. Comparing base (78a0ce6) to head (0fbe95c).

Files with missing lines Patch % Lines
src/nwp_emulator/grib_file_reader.cc 0.00% 16 Missing ⚠️
tests/nwp_emulator/nwp_emulator_plugin.h 70.00% 3 Missing ⚠️
tests/nwp_emulator/nwp_emulator_plugin.cc 92.30% 1 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           feature/nwp-emulator-config-source       #7       +/-   ##
=======================================================================
+ Coverage                               24.21%   48.87%   +24.65%     
=======================================================================
  Files                                      52       54        +2     
  Lines                                    2399     2478       +79     
  Branches                                  249      241        -8     
=======================================================================
+ Hits                                      581     1211      +630     
+ Misses                                   1818     1267      -551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cducher cducher force-pushed the feature/nwp-emulator-tests branch 2 times, most recently from b06b4ef to 0c75f18 Compare March 13, 2025 17:29
@cducher cducher force-pushed the feature/nwp-emulator-tests branch from 0fc3592 to 8069cd9 Compare March 24, 2025 11:42
@cducher cducher force-pushed the feature/nwp-emulator-config-source branch from a41cbd9 to 78a0ce6 Compare March 24, 2025 12:16
@cducher cducher force-pushed the feature/nwp-emulator-tests branch from 8069cd9 to 0fbe95c Compare March 24, 2025 13:48
@cducher cducher merged commit ea551fd into feature/nwp-emulator-config-source Mar 24, 2025
108 checks passed
@cducher cducher deleted the feature/nwp-emulator-tests branch March 24, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants