Fix VtsHalLightTargetTest VTS failures - #10
Merged
akanisetti merged 1 commit intoJul 15, 2026
Merged
Conversation
On virtual devices such as CaaS, none of the probed sysfs backlight paths exist (intel_backlight, acpi_video0, lcd-backlight, leds/lcd-backlight). The previous Default::default() always registered a BACKLIGHT HwLight regardless, but then setLightState for that light would fail in write_backlight because backlight_dev is None. This violates the ILights HAL contract: every light returned by getLights() must accept setLightState() successfully, causing VtsHalLightTargetTest Lights/LightsAidl#TestSupported to fail. Fix: in Default::default(), call determine_backlight_device() at construction time and only include the BACKLIGHT entry in the advertised list when a real sysfs device was found. On CaaS the list is empty; all six VtsHalLightTargetTest cases pass trivially (empty iteration) or via correct UNSUPPORTED_OPERATION for the invalid-ID case. On physical hardware with a backlight the behaviour is unchanged. Tracked-On: NIACP3-1474 Signed-off-by: Suresh, Prashanth <prashanth.suresh@intel.com>
prashanth-intel
force-pushed
the
NIACP3-1474-light-vts
branch
from
July 8, 2026 20:45
30de0d1 to
239a9b3
Compare
prashanth-intel
changed the title
prashanth-intel
marked this pull request as ready for review
July 9, 2026 15:18
bnkoppad
approved these changes
Jul 15, 2026
akanisetti
merged commit Jul 15, 2026
b9ccaba
into
edge-aosp-bsp:celadon/a15/master
0 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.