Fix mgmt command write size check - #7
Open
akanisetti wants to merge 6 commits into
Open
Conversation
Using AIDL Implementation for Lights. The passthrought solution is not used anymore. Delete the code. Tracked-On: NIACP3-1149 Signed-off-by: somkarx <suhasx.omkar@intel.com>
Implement custom AIDL Lights HAL to support display brightness control by decoding ARGB values, converting to luminance, and scaling to device-specific backlight range using sysfs. Includes backlight device detection and brightness remapping to ensure minimum visible levels, enabling proper UI brightness control. Tracked-On: NIACP3-1149 Signed-off-by: somkarx <suhasx.omkar@intel.com>
Add new location HAL module implementing vendor AIDL interface for static location coordinate provisioning. Includes HAL daemon with configuration file parsing, binder service registration, and location coordinate access. Tracked-On: NIACP3-1182 Signed-off-by: Anisetti Avinash Krishna <anisetti.avinash.krishna@intel.com>
- Add AIDL interface declaration to init.rc for ServiceManager discovery - Return error status from getLatitude/getLongitude on config read failures - Include line numbers in config parse error warnings - Fix unused lineNum variable warning Tracked-On: NIACP3-1182 Signed-off-by: Anisetti Avinash Krishna <anisetti.avinash.krishna@intel.com>
Add north pole as default location value. Read location will return North pole if conf file is not found. Tracked-On: NIACP3-1353 Signed-off-by: Anisetti Avinash Krishna <anisetti.avinash.krishna@intel.com>
Replace hardcoded 6 with sizeof(cmd) in mgmt command write. Compare write result with explicit ssize_t casts. Prevents wrong-size argument warnings with no behavior change. Tracked-On: NIACP3-1397 Signed-off-by: Anisetti Avinash Krishna <anisetti.avinash.krishna@intel.com>
akanisetti
force-pushed
the
coverity-fix-wave-1
branch
from
June 17, 2026 03:22
bca1bab to
f0d0292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hardcoded 6 with sizeof(cmd) in mgmt command write. Compare write result with explicit ssize_t casts.
Prevents wrong-size argument warnings with no behavior change.
Tracked-On: NIACP3-1397