Add Arrow Flight SQL client #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMax153
force-pushed
the
feat/arrow-flight-client
branch
from
a8f68cf to
d80ab1b
Compare
cmwhited
approved these changes
Dec 8, 2025
Contributor
cmwhited
left a comment
cmwhited
left a comment
There was a problem hiding this comment.
Didn't check each piece against flechette/apache-arrow. But looks good. Left some comments, one thing is the diff between /reader.ts and the split out readers in the readers dir
fubhy
requested changes
Dec 11, 2025
fubhy
left a comment
fubhy
left a comment
There was a problem hiding this comment.
This is a great first step. I'm missing tests (a lot) and documentation (a lot). Please augment the code with both (feel free to use your guy for that but let's carefully review everything obviously). Especially for these foundational things, the more we can infuse the source code with context for further development, the better for future sessions.
cmwhited
reviewed
Dec 11, 2025
fubhy
reviewed
Dec 12, 2025
…ta and RecordBatch for testing (#3) * test(harness): add vitest deps. setup vitest config. validate with test * test(harness): small fixes * test(harness): build out arrow flight message and recordbatch builder test harness impl * rebase --------- Co-authored-by: Maxwell Brown <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.