100 days party (+ Storage Module Basis) #34
Conversation
…getStorageDevices method
…torage and percentage values before output
| return []; | ||
| } | ||
|
|
||
| return json_decode($storage_devices_list_option->getValue(), true); |
There was a problem hiding this comment.
Def thinking the way we're decoding these options into json arrays we should perhaps think about mapping these to real types... not sure what would be best as we could manually do it for the PHP side which would be sufficient but it's also from the go side right pushing them in.. opinions?
There was a problem hiding this comment.
Yeah, agree about decoding into native types, as we can potentially validate the data even before it gets into the controller.
Validation is happening on the Go side thanks to Marshall and Unmarshall requirement of having to define these json structures as go types.
I also agree that we can use pure PHP for this, and gain a few neat features such as data types and expected values validation, a better structured codebase and thus cleaner code, and way less confusion on the controller side.
My suggestion is that we create the types and a class for serializing and deserializing these types from and to json. Then we replace the current option calls in the codebase with the native types ones which return known structures to PHP. Will be fun 😉
I see a good potential improvement here. Let's open a new issue based on this as the scope of doing it is probably gonna touch more parts of the codebase.
There was a problem hiding this comment.
Opened issue #37 so we can follow up on this ;)
|
|
||
| <div class=""> | ||
| <div class="" style="margin-top: -25px;"> | ||
| {# {{ include('partials/_row_title_block.html.twig', {main_title: 'Your Storage Buckets', button_title: 'Create Bucket', button_link: '/storage/bucket/new', new_tab: false})}} |
There was a problem hiding this comment.
Should this be commented out?
There was a problem hiding this comment.
Yes, was just an experiment, but storage buckets will be a whole new feature to be worked in the scope of another PR / Sprint.
Just left it there as I mocked a base UI, can be useful to quickly get going when we get to it.
Co-authored-by: Malachi Soord <[email protected]>
…ytes arg type to float
Uptime milestones (100 days and 1 year) will be given a little celebration emoji :)
PS: Needs prior merge from storage-module, please merge
storage-modulebranch to main first. Then dogit merge storage-module --no-ffbefore merging this one