Conduit #7
Open
Conduit #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inverse
approved these changes
Jul 3, 2021
| build: | ||
| context: "./bin/conduit-ws" | ||
| args: | ||
| CREATED: '2021-07-01T22:44:00Z' |
There was a problem hiding this comment.
Does this value hold any relevance?
There was a problem hiding this comment.
Not for us, but it is used in the Dockerfile for building, as recommended in the repo.
It has the entire project in order to build it in the machine :/ Would like to have something more streamlined. I think we could change the Dockerfile so it starts by pulling from the repo instead of having the project files in the package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the home-assistant branch, but should be able to be merged without trouble :)
Conduit is a Rust implementation of the Matrix reference server.
There are some thing impeding this package from working out-of-the box (using the install option via the dashboard interface).
(Some of these tasks can only be accomplished properly by rewriting WS in a language that allows us to handle more complexities around forming the final compose file, running post-install and ad-hoc commands with value dependencies coming from the interface, and reloading the containers faster).