Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Skills section to the project, allowing users to add, remove, and display their selected skills.
- Added a skills constant file listing available skills and logos.
- Integrated skills selection and saving functionality in SocialsBlock, passing the selected skills to the HomePage and BentoGrid for display and API processing.
- Updated Bento1.tsx to include the skills array in API calls and render the skills section.
Reviewed Changes
Copilot reviewed 56 out of 56 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/constant/skills.ts | Added a list of skill options with names and logos to support the new section. |
| src/components/SocialBlock.tsx | Implemented skills selection UI, including add/remove functionality and state propagation. |
| src/components/Home.tsx | Passed the new skills state to child components and updated the grid layout. |
| src/components/Bento1.tsx | Modified API URL construction to include the selected skills and added a skills display section. |
| src/components/BioBlock.tsx | Minor formatting update. |
Comments suppressed due to low confidence (3)
src/components/SocialBlock.tsx:41
- [nitpick] Consider adding unit tests for the skills selection functionality in SocialsBlock to ensure that adding and removing skills correctly updates both the component state and the parent state.
const [selectedSkills, setSelectedSkills] = useState<string[]>([]);
src/constant/skills.ts:35
- [nitpick] Consider renaming 'GoLang' to 'Go' for consistency with the official language name and common usage.
{ name: "GoLang", logo: "/logos/golang.png" },
src/components/Bento1.tsx:121
- Ensure that the API endpoint correctly parses the stringified skills array passed via the 's' query parameter, and consider adding error handling if the parsing fails.
)}&s=${encodeURIComponent(JSON.stringify(skills))}`;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have added the skills section as you mentioned in the issues. DON'T MERGE this to MAIN branch as I couldn't test it properly (probably because of CORS configuration).
Also I apologize for ruining the layout. I couldn't think of any other way of adding the Skills section. (:sob:)
Either way, your project is a really cool project! Let me know if my code was any useful and if I can be of any more use. 😄
Some (probably) important points:
You can find the whole list of skills with their logos in the "/constant/skills.ts" directory. I couldn't think of any more skills so those are all I could add. To add more simply add more skills like:
{ name: "Example", logo: "/logos/example.png" },.Test and ensure that the download and the "link" feature works with the skills section. In the
Bento1.tsxtake a look at line 121 and 156 to find the code added for handling download and "link" feature.The changes were also made in
Home.tsx.