Skip to content

Conversation

Akanshu-2u
Copy link
Contributor

Description:

This PR approaches the contraction of the FEATURES dict to enable top level settings.

Solution:

  • Contracted FEATURES dict within:

    • main.yml
    • studio.yml
    • lms.yml

Related PRs

JIRA Ticket:

BOMS-200

@Copilot Copilot AI review requested due to automatic review settings September 22, 2025 14:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the configuration structure by removing the nested FEATURES dictionary and promoting its settings to top-level configuration variables across edxapp deployment files.

  • Removes the EDXAPP_FEATURES_DEFAULT and EDXAPP_FEATURES dictionary definitions from main.yml
  • Eliminates the FEATURES dictionary wrapper in studio.yml and lms.yml while preserving all feature settings
  • Promotes all feature flags to top-level configuration settings for better accessibility

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
playbooks/roles/edxapp/defaults/main.yml Removes FEATURES dict definitions and references while keeping individual feature variables
docker/build/edxapp/studio.yml Removes FEATURES wrapper and duplicate feature settings, keeping top-level feature flags
docker/build/edxapp/lms.yml Removes FEATURES wrapper and duplicate feature settings, keeping top-level feature flags

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Akanshu-2u Akanshu-2u merged commit c6f7d86 into master Sep 25, 2025
3 checks passed
@Akanshu-2u Akanshu-2u deleted the BOMS-200-handle-features-setting-dict-depr branch September 25, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants